add (dummy) dispatch.dropExports to liveslots, test that it can be called #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
force-pushed
the
2653-dummy-dropexports
branch
from
a470720 to
ff94e1c
Compare
warner
force-pushed
the
2615-add-dropImport
branch
from
b19e9b1 to
074c8a9
Compare
warner
force-pushed
the
2653-dummy-dropexports
branch
from
ff94e1c to
613c165
Compare
|
This new version (613c165) adds |
|
Oops, I have one more commit to add to this, I forgot to wire Also, it's failing because of some XS thing.. which I thought I made optional, weird. |
warner
force-pushed
the
2615-add-dropImport
branch
from
074c8a9 to
e4f869e
Compare
warner
force-pushed
the
2653-dummy-dropexports
branch
2 times, most recently
from
67dade8 to
da1c505
Compare
FUDCo
approved these changes
Mar 19, 2021
warner
force-pushed
the
2615-add-dropImport
branch
from
6713c50 to
f9b5133
Compare
warner
force-pushed
the
2653-dummy-dropexports
branch
2 times, most recently
from
068fb62 to
2b7b09b
Compare
|
There's a small overlap between this and #2680, so I'm going to hold off landing it until that one lands. |
warner
force-pushed
the
2653-dummy-dropexports
branch
from
2b7b09b to
b1080f0
Compare
…gers The new `dropExports()` doesn't do anything yet, but at least test that it can be called directly in liveslots and comms. It should be reachable through all vat worker types, but I won't be able to test that until we have a kernel mechanism to provoke it. closes #2653
warner
force-pushed
the
2653-dummy-dropexports
branch
from
b1080f0 to
9fabfdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
dropExports()doesn't do anything yet, but at least test that itcan be called directly in liveslots. It should be reachable through all vat
worker types, but I won't be able to test that until we have a kernel
mechanism to provoke it.
closes #2653
refs #2615